Thread: Noobish C Fail - 'Permission Denied' - recreating Soundex code

Quote: Originally Posted by Caustic Okay, so yes, that does make sense. Cool. Does that mean my shift function still needs changing though?

Quote: Originally Posted by peteruk Does that mean my shift function still needs changing though? Yes, you must make sure that all array indexing stays inside its bounds. C does no checks to detect (or stop) this and array out-of-bounds problems will cause major headaches later. EDIT: However, there is always an exception to the rules. Strings in C are null terminated. So the string "test" is stored using 5 bytes,...

devowel asks for a char *, so you need to dereference the pointer when you call the function like this: devowel(&B);

For a start you can't call Code: a[26] ='\0'; when you intialised the array with Code: char a[26]; As you are accessing the 27th element (it's numbered from 0-25) So you'll be getting memory corruption issues right there. Same with Code: for (i=0,i<=20,i++) You're trying to access the 21st element. And surely you don't want Code: scanf ("%f",B); As thats reading in floats? Surely you...

Have a look at strpbrk

You could use a While loop which stops when the character is null then you will not need to do the count and will notoverflow the inputted string. Code: int something( char * s ) { while( *s++ ) { //do your business } return //an int } But as thats a bit of a pain to read you can always just do the strlen inside the function rather than having to pass it in and make it a bit nicer to use.