Lvalue Issue @ctransferwnd::showqueuecount | Thread profile

I'm not an expert however the below seems very bad : CODE _sntprintf(buffer, _countof(buffer), _T("%u (%u ") + GetResString(IDS_BANNED) .MakeLower() + _T(")"), number, theApp.clientlist->GetBannedCount()); I've changed to : CODE // By Taz - fix CString temp; temp = GetResString(IDS_BANNED); _sntprintf(buffer, _countof(buffer), _T("%u (%u ") + temp .MakeLower()...

? And why do you think that this is an issue?

Shouldn't Makelower() be invoked on "regular" stack based var and not on intermediate pointer returned by GetResString ?

CString != char * --------------------

QUOTE(the Doctor @ Jun 24 2008, 12:09 PM) CString != char * and if so ... If there's another GetResString(same IDS) elsewhere the compiler will identify both as "same" thus possibly produce only one ("optimization"). The Makelower in such a case will affect the other usage of the GetResString call as well ... This post has been edited by taz-me : Jun 24 2008, 10:32...

The CString assign operator is different form a char pointer assign operator. Create a ATL console application and check: CODE #include "stdafx.h" #include <iostream> #include <atlstr.h> using namespace std; int _tmain(int argc, _TCHAR* argv[]) { char * lpzStart = "StringNUMBER1"; CString strStart = lpzStart; cout << "strStart="<< strStart.MakeLower() << endl; cout ...

QUOTE(the Doctor @ Jun 24 2008, 12:59 PM) The CString assign operator is different form a char pointer assign operator. Create a ATL console application and check: CODE #include "stdafx.h" #include <iostream> #include <atlstr.h> using namespace std; int _tmain(int argc, _TCHAR* argv[]) { char * lpzStart = "StringNUMBER1"; CString strStart = lpzStart ; cout << "strStart...

No you are wrong, it would have to be: CString a(L"Kuku"); CString b(L"Kuku").MakeLower(); GetResString returns a CString object and the above code is correct... I wonder how you found this to be a possible "bug"!? Don't you think IF this were some kind of issue then it'd been found years ago?

Since an example does not convince you look carefully at the Borg archives: Basic CString operations In this case "Basic" point to simple, not the ancient computer language. --------------------

QUOTE(tHeWiZaRdOfDoS @ Jun 24 2008, 01:47 PM) No you are wrong, it would have to be: CString a(L"Kuku"); CString b(L"Kuku").MakeLower(); GetResString returns a CString object and the above code is correct... I'm not that sure since in the example you show MakeLower would be invoked on "b" which is obviously stored on different location then "a". On original (official) code...